Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Clean up code #310

Merged
merged 2 commits into from
Dec 2, 2024
Merged

[FIX] Clean up code #310

merged 2 commits into from
Dec 2, 2024

Conversation

elephaint
Copy link
Contributor

@elephaint elephaint commented Nov 29, 2024 •
edited
Loading

  • Cleans up old aggregation function
  • Fixes minor function that always returned pandas df. It now takes a string argument backend that will return a df of the chosen backend
  • Improve type annotation
  • Removes asserts in favor of ValueErrors

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@elephaint elephaint added the fix label Nov 29, 2024
@elephaint elephaint marked this pull request as ready for review November 29, 2024 09:47
jmoralez
jmoralez previously approved these changes Nov 29, 2024
View reviewed changes
hierarchicalforecast/utils.py Outdated Show resolved Hide resolved
hierarchicalforecast/utils.py Outdated Show resolved Hide resolved
@elephaint elephaint merged commit 375f717 into main Dec 2, 2024
17 checks passed
@elephaint elephaint deleted the fix/clean_up branch December 2, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmoralez jmoralez jmoralez approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elephaint @jmoralez